move viscosity averaging function #6008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
/rebuild |
|
/rebuild |
gassmoeller
reviewed
Aug 14, 2024
|
@gassmoeller that is probably true, but it would require more code refactoring. I'm happy to either stick with what I have here or do the refactoring. |
gassmoeller
reviewed
Aug 20, 2024
|
|
||
| /** | ||
| * Parse an AveragingOperation and alias to an AveragingOperation | ||
| * that is appropriate for viscosity averaging. |
There was a problem hiding this comment.
Please extend the description of the function, I had to read the implementation to understand what is happening here. Something like the following:
* Parse an AveragingOperation and alias to an AveragingOperation
* that only averages viscosity. In the case of any averaging operation
* that averages all properties the corresponding operation for only
* viscosity is selected (e.g. 'harmonic_average_only_viscosity' instead
* of 'harmonic_average'). This is useful in places where averaging is
* performed manually on only the viscosity property.
gassmoeller
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
get_averaging_operation_for_viscosity()function frommaterial_model/rheology/elasticity.ccintomaterial_model/interface.cc.This is a more logical place for the function, and makes it more easily accessible by rheology and material_model modules.
Addresses a single comment here: #5984 (comment)